- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Evaluate inline const pat early and report error if too generic #91570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | (rust-highfive has picked a reviewer for you, use r? to override) | 
| r? @RalfJung for review or reassignment | 
| Pattern matching is completely out of my realm, I am afraid. | 
| @bors r+ rollup Good idea! The eager eval makes sense as we never handle generics in patterns anyway. | 
| 📌 Commit 2a95958 has been approved by  | 
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 8, 2021 
    
    
      
  
    
      
    
  
Evaluate inline const pat early and report error if too generic Fix rust-lang#90150 `@rustbot` label: T-compiler F-inline_const
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 8, 2021 
    
    
      
  
    
      
    
  
Evaluate inline const pat early and report error if too generic Fix rust-lang#90150 ``@rustbot`` label: T-compiler F-inline_const
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 8, 2021 
    
    
      
  
    
      
    
  
Evaluate inline const pat early and report error if too generic Fix rust-lang#90150 ```@rustbot``` label: T-compiler F-inline_const
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Dec 8, 2021 
    
    
      
  
    
      
    
  
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90709 (Only shown relevant type params in E0283 label) - rust-lang#91551 (Allow for failure of subst_normalize_erasing_regions in const_eval) - rust-lang#91570 (Evaluate inline const pat early and report error if too generic) - rust-lang#91571 (Remove unneeded access to pretty printer's `s` field in favor of deref) - rust-lang#91610 (Link to rustdoc_json_types docs instead of rustdoc-json RFC) - rust-lang#91619 (Update cargo) - rust-lang#91630 (Add missing whitespace before disabled HTML attribute) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    F-inline_const
  Inline constants (aka: const blocks, const expressions, anonymous constants) 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fix #90150
@rustbot label: T-compiler F-inline_const